Skip to content

Conversation

luisvt
Copy link
Collaborator

@luisvt luisvt commented Jan 17, 2020

No description provided.

@crobinson42
Copy link
Member

@luisvt thx for the PR - did you by any chance check that the tests pass on any adapters? I assume you are bumping these because you're using a specific adapter.

@luisvt
Copy link
Collaborator Author

luisvt commented Jan 20, 2020

I haven't yet, I'm assuming it was not needed since I was only changing dev dependencies

@crobinson42
Copy link
Member

Ahh, you're correct. That slipped by me, sorry. What do you think about going all in for updating all the deps? It's been probably ~2+ years since the deps have been updated.

@luisvt
Copy link
Collaborator Author

luisvt commented Jan 20, 2020

Yes, I'm doing it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants